[Merge] lp:~mardy/webbrowser-app/cookie-domain into lp:webbrowser-app

[Chris Coulson]

> > One thing though: it looks like
> OxideCookieHelperTest::testSetCookiesSanity()
> > is incomplete. The setNetworkCookiesCalled signal spy is not used.
> 
> Copy/paste error: I'll remove that.
> 
> > And a question: how could we move this code to oxide (as you suggest in the
> > description), and why not implement it there in the first place?
> 
> Mainly for practical reasons, that's much easier to work with webbrowser-app
> than with Oxide (due to the building times and RAM requirements), but also
> because the two static methods which I added won't fit well in Oxide (which is
> just a QML module, and not a dynamic library); so at least those two will need
> to stay.
> 

I wouldn't object to splitting the existing QML module in to a small QML plugin and dynamic library with the public classes in. I think we're going to need to do this for bug 1260016 anyway
-- 
https://code.launchpad.net/~mardy/webbrowser-app/cookie-domain/+merge/235144
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.