[Merge] lp:~mardy/webbrowser-app/cookie-domain into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Fri Sep 19 10:41:30 UTC 2014
The code looks good to me overall.
One thing though: it looks like OxideCookieHelperTest::testSetCookiesSanity() is incomplete. The setNetworkCookiesCalled signal spy is not used.
And a question: how could we move this code to oxide (as you suggest in the description), and why not implement it there in the first place?
--
https://code.launchpad.net/~mardy/webbrowser-app/cookie-domain/+merge/235144
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list