[Merge] lp:~mardy/webbrowser-app/cookie-domain into lp:webbrowser-app

[Alberto Mardegan]

Alberto Mardegan has proposed merging lp:~mardy/webbrowser-app/cookie-domain into lp:webbrowser-app.

Commit message:
Support storing cookies for different domains

Create a new OxideCookieHelper class for managing writing cookies. This class's setCookies() groups the cookies by domain, and then fires up different calls to Oxide's setNetworkCookies(), one call per domain.


Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1371138 in webbrowser-app: "Can't transfer authentication cookies with gmail"
  https://bugs.launchpad.net/webbrowser-app/+bug/1371138

For more details, see:
https://code.launchpad.net/~mardy/webbrowser-app/cookie-domain/+merge/235144

Support storing cookies for different domains

Create a new OxideCookieHelper class for managing writing cookies. This class's setCookies() groups the cookies by domain, and then fires up different calls to Oxide's setNetworkCookies(), one call per domain.

This is a separate class, so that it is easily reusable in other components (Online Accounts might need it). And ideally, this logic could go into Oxide.
-- 
https://code.launchpad.net/~mardy/webbrowser-app/cookie-domain/+merge/235144
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mardy/webbrowser-app/cookie-domain into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 28938 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140918/7ef245fc/attachment-0001.diff>