[Merge] lp:~ycheng-twn/qtubuntu-camera/qtubuntu-camera_lp1365385 into lp:qtubuntu-camera

Yuan-Chen Cheng yc.cheng at canonical.com
Thu Sep 18 08:43:46 UTC 2014


Review: Resubmit

The failed test log:

FAIL!  : tst_AalImageCaptureControl::chooseOptimalSizeEmpty() Compared values are not the same
   Actual   (m_icControl->chooseOptimalSize(resolutions)): QSize(0x0)
   Expected (QSize())                                    : QSize(-1x-1)

It put a empty size list into it, and expect to return a empty QSize (which default to -1x-1) and I previous thought 0x0 will be a better way to imply not-valid size.

Revert to default behaviors.

@Jim could you please help on kick off another build and let me know what I can do on the way to release it.
-- 
https://code.launchpad.net/~ycheng-twn/qtubuntu-camera/qtubuntu-camera_lp1365385/+merge/233320
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu-camera.



More information about the Ubuntu-reviews mailing list