[Merge] lp:~lool/ubuntu-location-provider-here/cleanup-upstart-jobs into lp:ubuntu-location-provider-here

[Loïc Minier]

On Thu, Sep 18, 2014 at 6:04 AM, Steve Langasek <
steve.langasek at canonical.com> wrote:

> > +    # starting slpgwd should be enough to trigger the start of
> posclientd which
> > +    # will trigger the start of espoo provider
> >      start ubuntu-location-provider-here-slpgwd
>
> If this is the only service that you want to trigger the start of, then
> given the discussion in email about the fact that the EVENT=create event
> triggers on each boot for the existing files, perhaps this should not be a
> separate job at all but instead rolled into the start condition of the
> ubuntu-location-provider-here-slpgwd service?
>

It you mean adding an "or" to "start on", this was the original
implementation, but it didn't work because upstart considered it had
already started the job.

If you mean relying on only this to always start slpgwd and dropping the
other job, it would mean we require the wizard to have completed to start
the service when really we want the license acceptance to allow/prevent the
service to start.


>
> > -    start ubuntu-location-provider-here-posclientd
> > -    start ubuntu-espoo-service
> > +    #start ubuntu-location-provider-here-posclientd
> > +    #start ubuntu-espoo-service
>
> Please drop these lines rather than just commenting them (that's what VCS
> history is for!)
>

I've left intentionally to suggest that this would indirectly start the
other services.

Cheers,
-- 
Loïc

https://code.launchpad.net/~lool/ubuntu-location-provider-here/cleanup-upstart-jobs/+merge/234898
Your team Ubuntu Phablet Team is subscribed to branch lp:ubuntu-location-provider-here.