[Merge] lp:~albaguirre/platform-api/fix-1206146 into lp:platform-api

Alberto Aguirre alberto.aguirre at canonical.com
Wed Sep 17 23:49:32 UTC 2014


The proposal to merge lp:~albaguirre/platform-api/fix-1206146 into lp:platform-api has been updated.

Description changed to:

Fix memory leak on sensor event notifications (LP: #1206146)

The object instantiated by make_holder was leaked.

I did not see why two heap allocations and a copy where needed for an object whose lifetime is only the duration of the notification callback.

The callback receives an opaque pointer to such object and no api is provided to delete the event object provided.

So I've opted to just make a stack allocation.




For more details, see:
https://code.launchpad.net/~albaguirre/platform-api/fix-1206146/+merge/235066
-- 
https://code.launchpad.net/~albaguirre/platform-api/fix-1206146/+merge/235066
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~albaguirre/platform-api/fix-1206146 into lp:platform-api.



More information about the Ubuntu-reviews mailing list