[Merge] lp:~albaguirre/media-hub/fix-1368786 into lp:media-hub

Alberto Aguirre alberto.aguirre at canonical.com
Wed Sep 17 01:34:24 UTC 2014


Alberto Aguirre has proposed merging lp:~albaguirre/media-hub/fix-1368786 into lp:media-hub.

Commit message:
Fix wake lock state machine and subtle race conditions on wake lock refcounts.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1368786 in Media Hub: "Screen doesn't blank - krillin #32"
  https://bugs.launchpad.net/media-hub/+bug/1368786

For more details, see:
https://code.launchpad.net/~albaguirre/media-hub/fix-1368786/+merge/234900

Playing->stopped did not release the display wakelock (see gallery-app) which kept the screen up.

Also repeated press of play/pause in either media-player app or gallery-app resulted in:

ready->pause which acquired a display wakelock
and pause->playing which acquired another display wakelock but only one of those would be released.
-- 
https://code.launchpad.net/~albaguirre/media-hub/fix-1368786/+merge/234900
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~albaguirre/media-hub/fix-1368786 into lp:media-hub.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 7169 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140917/8be051a3/attachment.diff>


More information about the Ubuntu-reviews mailing list