[Merge] lp:~lool/ubuntu-location-provider-here/cleanup-upstart-jobs into lp:ubuntu-location-provider-here

[Loïc Minier]

Loïc Minier has proposed merging lp:~lool/ubuntu-location-provider-here/cleanup-upstart-jobs into lp:ubuntu-location-provider-here.

Commit message:
Cleanup upstart jobs to use common functions to set env var; refactor these to be more testing friendly.

Also, use dummy vars unless IMEI should be sent.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~lool/ubuntu-location-provider-here/cleanup-upstart-jobs/+merge/234898

Cleanup upstart jobs to use common functions to set env var; refactor these to be more testing friendly.

Also, use dummy vars unless IMEI should be sent.

NB: I'm getting dbus errors against accountservice because the jobs start earlier now; upstart retries and they eventually start.
-- 
https://code.launchpad.net/~lool/ubuntu-location-provider-here/cleanup-upstart-jobs/+merge/234898
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~lool/ubuntu-location-provider-here/cleanup-upstart-jobs into lp:ubuntu-location-provider-here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 12456 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140917/9c4f9826/attachment-0001.diff>