[Merge] lp:~phablet-team/gallery-app/desktop-i18n into lp:gallery-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Sep 16 12:05:28 UTC 2014


Review: Needs Fixing

This isn’t correct either:

96	+set(DESKTOP_FILE_IN_IN_H ${CMAKE_CURRENT_BINARY_DIR}/desktop/${DESKTOP_FILE}.in.in.h)

DESKTOP_FILE_IN_IN_H needs to be relative to CMAKE_SOURCE_DIR (or to some other place known to the build system, and then you need to pass a -D parameter to xgettext again).

This can be easily verified: if I build the code locally, it won’t update the translation template anymore, whereas it should (at least the timestamp).
-- 
https://code.launchpad.net/~phablet-team/gallery-app/desktop-i18n/+merge/234679
Your team Ubuntu Phablet Team is subscribed to branch lp:gallery-app.



More information about the Ubuntu-reviews mailing list