[Merge] lp:~tiagosh/telephony-service/fallback-default-account into lp:telephony-service

Tiago Salem Herrmann tiago.herrmann at canonical.com
Thu Sep 11 20:48:24 UTC 2014


Tiago Salem Herrmann has proposed merging lp:~tiagosh/telephony-service/fallback-default-account into lp:telephony-service.

Commit message:
- Fix crash on the desktop
- Use default account for messaging as a fallback
- Display a dialog asking the user to choose a sim card when sending a message from messaging-menu and no default sim card is defined.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1367270 in indicator-messages (Ubuntu): "Message is lost when user replies to an SMS from the indicator without a default SIM"
  https://bugs.launchpad.net/ubuntu/+source/indicator-messages/+bug/1367270
  Bug #1368389 in telephony-service (Ubuntu): "telephony-service-handler crashed with SIGSEGV in AccountEntry::accountId()"
  https://bugs.launchpad.net/ubuntu/+source/telephony-service/+bug/1368389

For more details, see:
https://code.launchpad.net/~tiagosh/telephony-service/fallback-default-account/+merge/234382

- Fix crash on the desktop
- Use default account for messaging as a fallback
- Display a dialog asking the user to choose a sim card when sending a message from messaging-menu and no default sim card is defined.
-- 
https://code.launchpad.net/~tiagosh/telephony-service/fallback-default-account/+merge/234382
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~tiagosh/telephony-service/fallback-default-account into lp:telephony-service.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5881 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140911/76acd843/attachment.diff>


More information about the Ubuntu-reviews mailing list