[Merge] lp:~filip-sohajek/ubuntu/utopic/libgksu/fix-for-1338028 into lp:ubuntu/libgksu

[Łukasz Zemczak]

Review: Needs Fixing

Hello Filip!

First of all thank you for contributing to Ubuntu! Sadly, there are a few issues here. Let me list them below:

1) First of all, the code you have added does not work - it's not valid C code. String formatting in C requires slightly more work, so just adding a line of `"%s/.gksu.lock", getenv ("HOME")` will not result in the format string being substituted - in this case what happens is that you try to send 2 parameters to a function that takes only one, i.e. unlink("name_of_the_file");

The easiest way of doing it here is something of the lines:
 gchar *fname;

 // (...)
 
 fname = g_strdup_printf ("%s/.gksu.lock", getenv ("HOME"));
 unlink (fname);
 g_free (fname);

2) Usually in cases of introducing changes to a package directly it is best not to edit the source tree directly but doing it through patches. Please check the debian/patches/ directory to check how it's done - but we can also help out with this if anything.

3) Sadly, currently the libgksu package fails to build even without your changes. There seems to be a problem with the new toolchain being used, so we won't be able to get this change released anyway. What needs to be done is a merge from Debian, as they have the fixes required for this to work correctly again.

Thanks!
-- 
https://code.launchpad.net/~filip-sohajek/ubuntu/utopic/libgksu/fix-for-1338028/+merge/229379
Your team Ubuntu branches is requested to review the proposed merge of lp:~filip-sohajek/ubuntu/utopic/libgksu/fix-for-1338028 into lp:ubuntu/libgksu.