[Merge] lp:~phablet-team/gallery-app/share-from-selection into lp:gallery-app
Ugo Riboni
ugo.riboni at canonical.com
Wed Sep 10 22:02:31 UTC 2014
Ugo Riboni has proposed merging lp:~phablet-team/gallery-app/share-from-selection into lp:gallery-app.
Commit message:
Allow sharing from the events or photo view, while selecting.
Requested reviews:
Ubuntu Phablet Team (phablet-team)
Related bugs:
Bug #1366820 in gallery-app: "sharing broken from Photos tab"
https://bugs.launchpad.net/gallery-app/+bug/1366820
For more details, see:
https://code.launchpad.net/~phablet-team/gallery-app/share-from-selection/+merge/234215
Allow sharing from the events or photo view, while selecting.
There are a few problems left in this MR:
- the header should hide when the share peer picker is displayed
- the share button in the header does not visually show as disabled, even though it is
- currently no application knows how to handle shares of multiple media. however the share peer picker displays these apps anyway (facebook and messaging). for this reason the selection is only enabled when there's a single item selected
--
https://code.launchpad.net/~phablet-team/gallery-app/share-from-selection/+merge/234215
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/gallery-app/share-from-selection into lp:gallery-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 7338 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140910/32172a3c/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list