[Merge] lp:~renatofilho/messaging-app/fix-1269017 into lp:messaging-app

Marco Trevisan (Treviño) mail at 3v1n0.net
Wed Sep 10 15:26:09 UTC 2014


About the license, the website source of these fonts states:

«Fonts in this site are offered free for any use; they may be installed, embedded, opened, edited, modified, regenerated, posted, packaged and redistributed. George Douros»

So... It seems fair.

Diff comments:

> === modified file 'debian/control'
> --- debian/control	2014-08-19 15:24:14 +0000
> +++ debian/control	2014-09-10 13:07:12 +0000
> @@ -36,6 +36,7 @@
>           qtdeclarative5-ubuntu-contacts0.1 (>= 0.2+14.10.20140805),
>           qtdeclarative5-qtcontacts-plugin,
>           qml-module-qt-labs-settings,
> +	 ttf-ancient-fonts-symbola,

Probably better to use spaces, instead of a tab.

>  Recommends: unity8 (>= 7.81.0~),
>  Description: messaging application for Ubuntu
>   An application to send and receive messages.
> 
> === modified file 'src/qml/MainPage.qml'
> --- src/qml/MainPage.qml	2014-09-04 03:08:20 +0000
> +++ src/qml/MainPage.qml	2014-09-10 13:07:12 +0000
> @@ -112,7 +112,7 @@
>          }
>      ]
>  
> -    Item { 
> +    Item {
>          id: emptyStateScreen
>          anchors.left: parent.left
>          anchors.leftMargin: units.gu(6)
> 


-- 
https://code.launchpad.net/~renatofilho/messaging-app/fix-1269017/+merge/233986
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~renatofilho/messaging-app/fix-1269017 into lp:messaging-app.



More information about the Ubuntu-reviews mailing list