[Merge] lp:~gerboland/qtubuntu/exposeOrientation into lp:qtubuntu
Daniel d'Andrada
daniel.dandrada at canonical.com
Mon Sep 8 13:29:47 UTC 2014
Review: Needs Fixing
In src/ubuntumirclient/screen.cpp:
"""
- case QOrientationReading::LeftUp: {
+ case QOrientationReading::RightUp: {
mCurrentOrientation = (mNativeOrientation == Qt::LandscapeOrientation) ?
- Qt::InvertedPortraitOrientation : Qt::LandscapeOrientation;
+ Qt::InvertedPortraitOrientation : Qt::InvertedLandscapeOrientation;
"""
This is wrong. The original code had the correct conversion.
"""
- case QOrientationReading::RightUp: {
+ case QOrientationReading::LeftUp: {
mCurrentOrientation = (mNativeOrientation == Qt::LandscapeOrientation) ?
- Qt::PortraitOrientation : Qt::InvertedLandscapeOrientation;
+ Qt::PortraitOrientation : Qt::LandscapeOrientation;
"""
Same here.
See https://www.dropbox.com/s/4ctoecuq4269j5m/QtScreenOrientation.png?dl=0
--
https://code.launchpad.net/~gerboland/qtubuntu/exposeOrientation/+merge/232252
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.
More information about the Ubuntu-reviews
mailing list