[Merge] lp:~phablet-team/ofono/lp1363413 into lp:~phablet-team/ofono/ubuntu

Tony Espy espy at canonical.com
Thu Sep 4 22:17:24 UTC 2014


Tony Espy has proposed merging lp:~phablet-team/ofono/lp1363413 into lp:~phablet-team/ofono/ubuntu.

Commit message:
  * src/gprs.c: Fix to allow MMS properties to be set (LP: #1362068)
  * rilmodem/sim.c: Fix EnterPIN logic (LP: #1363413)


Requested reviews:
  PS Jenkins bot (ps-jenkins): continuous-integration
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1362068 in ofono (Ubuntu): "setting ConnectionContext MessageCenter or MessageProxy always returns "invalid parameters""
  https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1362068
  Bug #1363413 in ofono (Ubuntu): "Can't unlock SIM card"
  https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1363413

For more details, see:
https://code.launchpad.net/~phablet-team/ofono/lp1363413/+merge/233434

This change fixes a regression introduced by the last merge request.  This happened as even though the SIM portion of the ofono test plan was updated for the previous landing, not all of the manual SIM test cases were runnning, and thus the entering a SIM PIN broke ( lp: #1363413 ).

This change also includes a minor bug fix to allows MMS-specific DBus properties to be set for GPRS context objects that are of type=Internet or type=MMS.  This bug fix is required for the new SystemSettings::Cellular APN Editor.  None of the existing software on touch uses this DBus method.
-- 
https://code.launchpad.net/~phablet-team/ofono/lp1363413/+merge/233434
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/ofono/lp1363413 into lp:~phablet-team/ofono/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2169 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140904/4b6aeba3/attachment.diff>


More information about the Ubuntu-reviews mailing list