[Merge] lp:~serge-hallyn/ubuntu/utopic/systemd-shim/shim-abandoncg into lp:ubuntu/systemd-shim

Serge Hallyn serge.hallyn at ubuntu.com
Wed Sep 3 22:03:22 UTC 2014


Serge Hallyn has proposed merging lp:~serge-hallyn/ubuntu/utopic/systemd-shim/shim-abandoncg into lp:ubuntu/systemd-shim.

Requested reviews:
  Ubuntu branches (ubuntu-branches)

For more details, see:
https://code.launchpad.net/~serge-hallyn/ubuntu/utopic/systemd-shim/shim-abandoncg/+merge/233280

This is the proposed fix for 1359439.

Note that if it is possible for upstart job pre-start and start scripts to have lingering tasks, and if KillUserProcesses=no, then such a race is still possible.  So if that happens, then we will want to drop the RemoveOnEmpty in the Abandon case, and accept that some cgroups may never be removed, or set KilluserProcesses=yes, or make sure upstart kills the processes, or (finally) have upstart use different cgroups for each job state.
-- 
https://code.launchpad.net/~serge-hallyn/ubuntu/utopic/systemd-shim/shim-abandoncg/+merge/233280
Your team Ubuntu branches is requested to review the proposed merge of lp:~serge-hallyn/ubuntu/utopic/systemd-shim/shim-abandoncg into lp:ubuntu/systemd-shim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 23796 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140903/e6d3b854/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list