[Merge] lp:~rsalveti/livecd-rootfs/exportin_ubuntu-system-settings_qml2_import_patch into lp:livecd-rootfs

Alberto Mardegan alberto.mardegan at canonical.com
Wed Sep 3 08:26:21 UTC 2014


Review: Disapprove

I wouldn't like to have the QML2_IMPORT_PATH altered for all applications, it seems to me like a very bad idea.

libsystemsettings-dev ships a pkgconfig file, SystemSettings.pc, which defines a variable named "plugin_private_module_dir", which holds the value of this path:

    $ pkg-config --variable=plugin_private_module_dir SystemSettings
    /usr/lib/x86_64-linux-gnu/ubuntu-system-settings/private
    $

Applications which need to use the system settings QML modules should get the value of this variable and append it to their import path. There is no need to alter the import paths for all applications.
-- 
https://code.launchpad.net/~rsalveti/livecd-rootfs/exportin_ubuntu-system-settings_qml2_import_patch/+merge/233149
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~rsalveti/livecd-rootfs/exportin_ubuntu-system-settings_qml2_import_patch into lp:livecd-rootfs.



More information about the Ubuntu-reviews mailing list