[Merge] lp:~canonical-platform-qa/dialer-app/qmltests1 into lp:dialer-app

Leo Arias leo.arias at canonical.com
Tue Sep 2 21:25:51 UTC 2014


You have been requested to review the proposed merge of lp:~canonical-platform-qa/dialer-app/qmltests1 into lp:dialer-app.

For more details, see:
https://code.launchpad.net/~canonical-platform-qa/dialer-app/qmltests1/+merge/230412

Are there any related MPs required for this MP to build/function as expected? Please list.

Yes, from boiko:
<boiko> btw, the failure on the qmltests branch is due to telephony-service's qml plugin not pulling the gsettings schemas, but I have an MR to fix that in the same silo

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

It is.

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

I ran the tests many times. They failed only on the schroot and boiko has now found the cause.

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?

No functionality changes, so no need to run manual tests.

If you changed the UI, was the change specified/approved by design?

No UI changes.

If you changed UI labels, did you update the pot file?

No UI changes.

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? 

Subscribing...

-- 
https://code.launchpad.net/~canonical-platform-qa/dialer-app/qmltests1/+merge/230412
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~canonical-platform-qa/dialer-app/qmltests1 into lp:dialer-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5428 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140902/26f2bdf5/attachment.diff>


More information about the Ubuntu-reviews mailing list