[Merge] lp:~gcollura/content-hub/fix-1384490 into lp:content-hub

Giulio Collura giulio.collura at gmail.com
Thu Oct 30 19:05:31 UTC 2014


Giulio Collura has proposed merging lp:~gcollura/content-hub/fix-1384490 into lp:content-hub.

Commit message:
Fix bug #1384490 by setting a different background color for ContentPeerPicker.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1384490 in content-hub: "Color issue of the hub's title"
  https://bugs.launchpad.net/content-hub/+bug/1384490

For more details, see:
https://code.launchpad.net/~gcollura/content-hub/fix-1384490/+merge/240156

I changed the default background of the ContentPeerPicker to Theme.palette.normal.background. If the the app has a dark background, ContentPeerPicker will have a proper background color (it's actually purple, point me to the correct color to choose). Ideally, the developer should be able to choose which background the component should have, maybe we could expose a property like "backgroundColor:".
Let me know what you think about this idea.

Thanks in advance,
Giulio
-- 
https://code.launchpad.net/~gcollura/content-hub/fix-1384490/+merge/240156
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~gcollura/content-hub/fix-1384490 into lp:content-hub.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1198 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20141030/7a717fa4/attachment.diff>


More information about the Ubuntu-reviews mailing list