[Merge] lp:~michael-sheldon/webbrowser-app/7digital-album-download into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Wed Oct 15 05:41:37 UTC 2014
The latest change looks good to me. A couple of questions:
- What happens to SingleDownload objects when the associated download completes? Are they automatically destroyed? Or are they leaked? (shouldn’t you give the object a parent when instantiating it with createObject(…)?)
- Is there a good reason for pre-instantiating the next SingleDownload object (i.e., is it a time-consuming operation)? If not, I’d suggest instantiating it on demand only, in the download() function (you’d need to add an optional metadata paramater to the function).
--
https://code.launchpad.net/~michael-sheldon/webbrowser-app/7digital-album-download/+merge/237763
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list