[Merge] lp:~daniel-thewatkins/ubuntu/precise/cloud-init/lp1374600 into lp:ubuntu/precise-proposed/cloud-init

Scott Moser smoser at ubuntu.com
Thu Oct 9 17:19:39 UTC 2014


Review: Needs Fixing

2 nit picks, other than that, assuming this is tested it looks fine.
The headers you're putting on the patch are described at http://dep.debian.net/deps/dep3/
so:
a.) add 'Origin: upstream'
    you can probably remove 'Author:' here (i realize we're probably not consistent in other patches on this).

b.) the bug number you referenced is a private bug (1374600), while there is a public bug (bug 1378441).  Seems to make sense to reference the public bug.

c.) reference the ubuntu bug in the changelog message.

so make those changes, and i'll upload for you.

-- 
https://code.launchpad.net/~daniel-thewatkins/ubuntu/precise/cloud-init/lp1374600/+merge/237813
Your team Ubuntu branches is subscribed to branch lp:ubuntu/precise-proposed/cloud-init.



More information about the Ubuntu-reviews mailing list