[Merge] lp:~abreu-alexandre/webbrowser-app/improve-redirection-prefix into lp:webbrowser-app

Alexandre Abreu alexandre.abreu at canonical.com
Thu Oct 9 00:41:57 UTC 2014


The proposal to merge lp:~abreu-alexandre/webbrowser-app/improve-redirection-prefix into lp:webbrowser-app has been updated.

Description changed to:

Improve redirection prefix handling. This is still not the ideal solution since the pattern itself is a 'hack' and the pattern could be tricky to get right, but until something better w/ oxide support lands (in the works) this should improve the situation.

Most of the changes are test related. The gist of the logic happens in the WebViewImplOxide.qml file and is triggered if and only if we have a redirection prefix (if isRedirectionUrl is true) therefore if and only if a webapp is started with --popup-redirection-url-prefix=. In that case the result of the pattern match is considered instead of a simple slice () to get the final URL.




For more details, see:
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/improve-redirection-prefix/+merge/234325
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/improve-redirection-prefix/+merge/234325
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list