[Merge] lp:~rpadovani/webbrowser-app/updateReadme into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Oct 8 22:00:15 UTC 2014


Review: Needs Fixing

Thanks for your attention to detail, this README should have been updated long ago!

The changes in the path are obviously correct, but I don’t think the new paragraph about build dependencies is needed. In fact, for it to be correct you would need to list all the build deps as found in debian/control (see http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/debian/control). But the README file is meant to be as distro-agnostic as possible, so I don’t think we should list debian packages there (that would just be duplicating the information already available in debian/control).
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/updateReadme/+merge/237671
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list