[Merge] lp:~hannahermsen/ubuntu/trusty/ristretto/bug-1284111 into lp:ubuntu/trusty/ristretto

[Łukasz Zemczak]

Review: Needs Fixing

Hey! Thank you for submitting these fixes to Ubuntu!

There are a few things that we would need to know and some things you need to do:
1. As per the comment in the bug (LP: #1284111), could you make sure that the bug is reported upstream and the proposed fixed also sent to the upstream project itself? Is that the case right now?
2. The fix seems to be applied invalidly to the source - the package doesn't want to build. You applied the changes to the source tree and did not create a patch (even though you modified the debian/patches/series file). This project uses quilt [1] as the patch system, so all additional source changes need a quilt patch - introducing local source changes is not possible. We can help out with this if needed.
3. You are targeting this merge to the trusty branch - is this bug also valid for utopic? We generally prefer first landing fixes into the current development series and only then backporting to previous releases.

Thanks again!

[1] https://wiki.debian.org/UsingQuilt
-- 
https://code.launchpad.net/~hannahermsen/ubuntu/trusty/ristretto/bug-1284111/+merge/225450
Your team Ubuntu branches is requested to review the proposed merge of lp:~hannahermsen/ubuntu/trusty/ristretto/bug-1284111 into lp:ubuntu/trusty/ristretto.