[Merge] lp:~ogra/ubuntu-touch-session/fix-oom-score-1377869 into lp:ubuntu-touch-session

Sergio Schvezov sergio.schvezov at canonical.com
Mon Oct 6 12:38:35 UTC 2014


Review: Approve

[09:32:35] <sergiusens> ogra: if you kill lightdm, what is the difference? isn't just moving the bug somewhere else?
[09:32:56] <sergiusens> isn't this change*...
[09:33:12] <ogra> sergiusens, but since cwayne added all these scopes who are not lifecycle managed at all, we now have higher memory pressure ... 
[09:33:38] <ogra> the wrong value in the lightdm job causes system processes to be killed *before* any session processes are 
[09:34:10] <ogra> lightdm is surely on the edge here ... first of all we want that dbus, powerd and firends survive though 
[09:34:59] <ogra> sergiusens, btw, this was discussed all morning already ... the value change is right 
[09:35:04] <ogra> also see http://paste.ubuntu.com/8505997/
[09:35:19] <ogra> all session stuff needs to be above 0
[09:35:35] <ogra> (container stuff has -941 by default ... systtem stuff has 0
[09:35:37] <ogra> )

[09:37:22] <sergiusens> ogra: I would still consider this a work around fix
[09:37:38] <ogra> lifecycle mgmt bases on the value set by lightdm and adds/subtracts from that 
[09:37:59] <ogra> sergiusens, well, we wont re-design the session management now ... :)
[09:38:17] <ogra> i agree that setting it in lightdm is wrong ... but we have done that since we started ... 
-- 
https://code.launchpad.net/~ogra/ubuntu-touch-session/fix-oom-score-1377869/+merge/237242
Your team Ubuntu Phablet Team is subscribed to branch lp:ubuntu-touch-session.



More information about the Ubuntu-reviews mailing list