[Merge] lp:~boiko/messaging-app/ship_icon into lp:messaging-app

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Fri Oct 3 23:06:24 UTC 2014


Gustavo Pichorim Boiko has proposed merging lp:~boiko/messaging-app/ship_icon into lp:messaging-app.

Commit message:
Ship the messaging-app icon together with the package

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1365408 in webbrowser-app (Ubuntu): "Should ship a PNG icon instead of using the theme"
  https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1365408

For more details, see:
https://code.launchpad.net/~boiko/messaging-app/ship_icon/+merge/237152

Ship the messaging-app icon together with the package

== Checklist ==
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A
-- 
https://code.launchpad.net/~boiko/messaging-app/ship_icon/+merge/237152
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~boiko/messaging-app/ship_icon into lp:messaging-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 687 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20141003/2009d661/attachment.diff>


More information about the Ubuntu-reviews mailing list