[Merge] lp:~thomas-voss/dbus-cpp/fix-1361642 into lp:dbus-cpp

Jussi Pakkanen jussi.pakkanen at canonical.com
Thu Oct 2 07:18:27 UTC 2014


Review: Needs Fixing

Instead of a magic number replicated in three different places, could you instead put it in a named constant?
-- 
https://code.launchpad.net/~thomas-voss/dbus-cpp/fix-1361642/+merge/236820
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~thomas-voss/dbus-cpp/fix-1361642 into lp:dbus-cpp.



More information about the Ubuntu-reviews mailing list