[Merge] lp:~jamesodhunt/goget-ubuntu-touch/add-list-images-option into lp:goget-ubuntu-touch

Sergio Schvezov sergio.schvezov at canonical.com
Wed Oct 1 20:23:32 UTC 2014


Review: Needs Fixing

you probably want to do something like this (or move it to a separate function maybe)

if args.ListImages
	if args.Device == "" {
		log.Fatal("You must specify a device type")
	}

	deviceChannel, err := channels.GetDeviceChannel(
		args.Server, args.Channel, args.Device)
	if err != nil {
		log.Fatal(err)
	}

	return deviceChannel.ListImageVersions()
}

and keep the original deviceChannel setup that in it's original location to avoid the from below to not break current "device" autodetection
-- 
https://code.launchpad.net/~jamesodhunt/goget-ubuntu-touch/add-list-images-option/+merge/236510
Your team Ubuntu Phablet Team is subscribed to branch lp:goget-ubuntu-touch.



More information about the Ubuntu-reviews mailing list