[Merge] lp:~artmello/camera-app/camera-app-self_timer into lp:camera-app

Florian Boucault florian.boucault at canonical.com
Fri Nov 28 10:11:12 UTC 2014


Review: Needs Fixing

1) countdown label should be bigger: maybe font.pixelSize: units.gu(6)
2) icon "reminder" is not good enough. I asked Matthieu (tiheum) from design to provide a better one. He will base it on the standard industry wise that looks like this: http://www.removethebackground.fr/wp-content/uploads/sites/41/2014/04/self-timer.png
3) settings labels should probably include the word 'seconds': for example "5 seconds" instead of just "5"
4) pot strings should be refreshed (copy over the pot file from the build dir to the source dir)
5) remaining seconds should appear right away when pressing the shoot button instead of a second afterwards
6) it seems there is no need for a start() function in timedShootFeedback; "viewFinderOverlay.visible = false" can be moved to timedShoot(). Especially since the revert operation is _not_ done in timedShootFeedback.
7) it feels like the function timedShoot() should not query the settings but instead take as argument the number of seconds that would be passed by the caller (shoot button)

-- 
https://code.launchpad.net/~artmello/camera-app/camera-app-self_timer/+merge/243093
Your team Ubuntu Phablet Team is subscribed to branch lp:camera-app.



More information about the Ubuntu-reviews mailing list