[Merge] lp:~thomas-voss/qtubuntu-media/reuse-precreated-objects into lp:qtubuntu-media

[Alberto Aguirre]

Review: Approve

I guess it's pre-existing but shouldn't AalMediaPlayerService constructor throw if it could not create a hubPlayerSession? I suppose this is because Qt wouldn't handle that very well?

	+    if (m_hubPlayerSession == NULL)
78	+        return QMediaPlayer::MultimediaRole;
79	+
80	     return static_cast<QMediaPlayer::AudioRole>(m_hubPlayerSession->audio_stream_role().get());
81	 }
82	 
83	 void AalMediaPlayerService::setAudioRole(QMediaPlayer::AudioRole audioRole)
84	 {
85	+    if (m_hubPlayerSession == NULL)
86	+        return;
87	+

I thought maybe that should probably be saved as a "pending to apply" setting but probably not wanted as we can have AalMediaPlayerService in a "bad" intermediate state anyway but that's all pre-existing so looks good to me.



-- 
https://code.launchpad.net/~thomas-voss/qtubuntu-media/reuse-precreated-objects/+merge/240644
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu-media.