[Merge] lp:~afrantzis/qtubuntu/fix-1321189 into lp:qtubuntu

[Alexandros Frantzis]

Alexandros Frantzis has proposed merging lp:~afrantzis/qtubuntu/fix-1321189 into lp:qtubuntu.

Commit message:
Set the surface renderable type to QSurfaceFormat::OpenGLES when using OpenGL ES 2.0

In Qt 5.3 the type of used GL context is checked at runtime to determine supported GL features. Set the surface renderable type properly so that Qt can determine the features correctly.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1321189 in qtubuntu: "Launcher is black on Qt 5.3"
  https://bugs.launchpad.net/qtubuntu/+bug/1321189

For more details, see:
https://code.launchpad.net/~afrantzis/qtubuntu/fix-1321189/+merge/220613

Set the surface renderable type to QSurfaceFormat::OpenGLES when using OpenGL ES 2.0

In Qt 5.3 the type of used GL context is checked at runtime to determine supported GL features. Set the surface renderable type properly so that Qt can determine the features correctly.

Previously (Qt <= 5.2) we could get away with not doing this because the GL vs GL ES 2.0 paths were hardcoded at build time with #ifdefs. With version 5.3 Qt has started moving to more dynamic (i.e. runtime) OpenGL vs OpenGL ES 2.0 decisions. I don't know what the state of this feature is, but it's worth investigating further to determine if/how it helps us decreasing our own GL build time decisions.
-- 
https://code.launchpad.net/~afrantzis/qtubuntu/fix-1321189/+merge/220613
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~afrantzis/qtubuntu/fix-1321189 into lp:qtubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 458 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140522/553de512/attachment.diff>