[Merge] lp:~robru/phablet-tools/citrain-improvements into lp:phablet-tools

Robert Bruce Park robert.park at canonical.com
Wed May 21 16:15:38 UTC 2014


On Wed, May 21, 2014 at 4:15 AM, Sergio Schvezov
<sergio.schvezov at canonical.com> wrote:
> This should be $2, right?

Not after calling 'shift' above. If you run the script you'll see it works ;-)

> The only other comment I have is, now that you are redoing it, do you mind
> adding multiple device checks? There is a shell thingie you can source now.

Your wish is my command! Check the updated diff.

Thanks!

-- 
https://code.launchpad.net/~robru/phablet-tools/citrain-improvements/+merge/220335
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~robru/phablet-tools/citrain-improvements into lp:phablet-tools.



More information about the Ubuntu-reviews mailing list