[Merge] lp:~tpeeters/webbrowser-app/fix-pagestack into lp:webbrowser-app

Tim Peeters tim.peeters at canonical.com
Wed May 14 16:41:33 UTC 2014


The proposal to merge lp:~tpeeters/webbrowser-app/fix-pagestack into lp:webbrowser-app has been updated.

Description changed to:

Push the initial Page on the PageStack.

This was never automatic, but there was a "bug" in UITK that made a single Page inside PageStack active and visible initially, but not on the PageStack (with multiple Pages inside PageStack the result was unpredictable), but that bug was fixed here https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/80-betterActive/+merge/219093

Please review the setting of properties (webview.enabled and browser.activityViewVisible) that depend on stack.depth because I don't fully know what is the logic there.

For more details, see:
https://code.launchpad.net/~tpeeters/webbrowser-app/fix-pagestack/+merge/219560
-- 
https://code.launchpad.net/~tpeeters/webbrowser-app/fix-pagestack/+merge/219560
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~tpeeters/webbrowser-app/fix-pagestack into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list