[Merge] lp:~tpeeters/webbrowser-app/fix-pagestack into lp:webbrowser-app
Tim Peeters
tim.peeters at canonical.com
Wed May 14 16:34:29 UTC 2014
Tim Peeters has proposed merging lp:~tpeeters/webbrowser-app/fix-pagestack into lp:webbrowser-app.
Commit message:
Push the initial Page on the PageStack.
Requested reviews:
Ubuntu Phablet Team (phablet-team)
For more details, see:
https://code.launchpad.net/~tpeeters/webbrowser-app/fix-pagestack/+merge/219560
Push the initial Page on the PageStack.
This was never automatic, but there was a "bug" in UITK that made a single Page inside PageStack active and visible initially (with multiple Pages inside PageStack the result was unpredictable), but that bug was fixed.
Please review the setting of properties (webview.enabled and browser.activityViewVisible) that depend on stack.depth because I don't fully know what is the logic there.
--
https://code.launchpad.net/~tpeeters/webbrowser-app/fix-pagestack/+merge/219560
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~tpeeters/webbrowser-app/fix-pagestack into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 877 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140514/d612e687/attachment.diff>
More information about the Ubuntu-reviews
mailing list