[Merge] lp:~sergiusens/udm/packaging into lp:udm

Sergio Schvezov sergio.schvezov at canonical.com
Tue May 13 19:42:16 UTC 2014


On Tue, May 13, 2014 at 1:22 PM, Robert Bruce Park <
robert.park at canonical.com> wrote:

> Review: Needs Fixing
>
> Changelog should be urgency=low. I have seen citrain have unexpected
> results from urgency=medium.
>

As Colin mentions, it's the tool's default


>
> Also, please `wrap-and-sort -a -t` to get the Dependencies: field wrapped
> properly, and add the "if you don't have have commit access..." comment as
> per https://wiki.ubuntu.com/DailyRelease/InlinePackaging
>

The thing I don't like about adding the comment is that wrap-and-sort wipes
it and I like to run it often (I clearly missed it this time :-P)


>
> debian/copyright has a copy&paste error, it references nuntium (twice),
> which is an unrelated project. Please change that to udm.
>

Nice catch


> Otherwise it mostly looks good.
>

Thanks

-- 
https://code.launchpad.net/~sergiusens/udm/packaging/+merge/219387
Your team Ubuntu Phablet Team is subscribed to branch lp:udm.



More information about the Ubuntu-reviews mailing list