[Merge] lp:~sergiusens/nuntium/ofonomanager into lp:nuntium

Manuel de la Peña manuel.delapena at canonical.com
Tue May 13 10:41:20 UTC 2014


Review: Needs Fixing

I think you probably want to return an error here:

281	+ if err != nil {
282	+ log.Print("Cannot preemptively add modems: ", err)
283	+ } else {

And the same happens here:

455	+ modem.updatePushInterfaceState(*v)
456	+ } else {
457	+ log.Print("Initial value couldn't be retrieved: ", err)
458	+ }
459	+ if v, err := modem.getProperty(MODEM_INTERFACE, "Online"); err == nil {
460	+ modem.handleOnlineState(*v)
461	+ } else {
462	+ log.Print("Initial value couldn't be retrieved: ", err)
463	+ }
464	+ if v, err := modem.getProperty(SIM_MANAGER_INTERFACE, "SubscriberIdentity"); err == nil {
465	+ modem.handleIdentity(*v)
466	+ }
-- 
https://code.launchpad.net/~sergiusens/nuntium/ofonomanager/+merge/219194
Your team Ubuntu Phablet Team is subscribed to branch lp:nuntium.



More information about the Ubuntu-reviews mailing list