[Merge] lp:~mandel/platform-api/add_missing_agps_hooks into lp:platform-api

Thomas Voß thomas.voss at canonical.com
Mon May 12 05:57:06 UTC 2014


Review: Needs Fixing

Thanks for taking over the MP :) One thing that needs to fixed with the GCC 4.8 transition in mind:

 * u_hardware_gps_inject_location should take its float arguments either by pointer, or encapsulated in a struct, thereby circumventing floating point calling convention issues. In this particular case, I would vote in favor of a struct.

-- 
https://code.launchpad.net/~mandel/platform-api/add_missing_agps_hooks/+merge/218939
Your team Ubuntu Phablet Team is subscribed to branch lp:platform-api.



More information about the Ubuntu-reviews mailing list