[Merge] lp:~renatofilho/sync-monitor/i18n into lp:sync-monitor

[David Planella]

Looks good to me, but note that I'm not a C++ expert. One thing I've noticed:

208	+ C::bindtextdomain("sync-monitor", LOCALE_PATH);
209	+ C::textdomain("sync-monitor");

I'd suggest to use variables here instead of hardcoding the domain. Also, I'm not sure if the textdomain() call is required if you call bindtextdomain() already.

For the variable names, I'd recommend to use to those that are generally defined by convention when working with gettext, e.g. GETTEXT_PACKAGE and GETTEXT_LOCALEDIR.

E.g.

setlocale(LC_ALL, "");
bindtextdomain(GETTEXT_PACKAGE, GETTEXT_LOCALEDIR);

 GETTEXT_PACKAGE -> ${PROJECT_NAME}
 GETTEXT_LOCALEDIR -> ${CMAKE_INSTALL_LOCALEDIR}

These merge proposals that have recently landed for scopes internationalization might also be useful to look at:

https://code.launchpad.net/~mhr3/unity-scope-mediascanner/i18n-enablement/+merge/217389
https://code.launchpad.net/~dobey/unity-scope-click/translated/+merge/214182
-- 
https://code.launchpad.net/~renatofilho/sync-monitor/i18n/+merge/215943
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~renatofilho/sync-monitor/i18n into lp:sync-monitor.