[Merge] lp:~altair-ibn-la-ahad/ubuntu/trusty/ubuntu-release-upgrader/fix-for-1313012 into lp:ubuntu/trusty/ubuntu-release-upgrader

Dmitry Shachnev mitya57 at gmail.com
Mon May 5 14:09:27 UTC 2014


Review: Resubmit

Thanks for your work.

- Please submit fixes against lp:ubuntu-release-upgrader, not against UDD branch. I am rejecting this one.
- (LP:# 1313012) is wrong syntax :-)
- exit `somecommand | wc -l` is a very weird way to check if command output is empty. I recommend you to use subprocess.PIPE instead and check the output yourself.
- I would even drop shell=True at all and manually search for "do-release-upgrade" in the output. No need for grep -v grep will be needed.
-- 
https://code.launchpad.net/~altair-ibn-la-ahad/ubuntu/trusty/ubuntu-release-upgrader/fix-for-1313012/+merge/218177
Your team Ubuntu branches is requested to review the proposed merge of lp:~altair-ibn-la-ahad/ubuntu/trusty/ubuntu-release-upgrader/fix-for-1313012 into lp:ubuntu/trusty/ubuntu-release-upgrader.



More information about the Ubuntu-reviews mailing list