[Merge] lp:~brandontschaefer/libsdl/enable-mir-support-ffe into lp:ubuntu/libsdl2

Colin Watson cjwatson at canonical.com
Fri Mar 21 09:22:23 UTC 2014


Review: Needs Fixing

A clearer and more robust way to spell the debian/rules test would be:

  DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
(put this together with the other similar variable settings, if not already set; you want DEB_HOST_ARCH for this and not DEB_HOST_ARCH_CPU, because e.g. you've missed that DEB_HOST_ARCH_CPU is "arm" on the armhf architecture)

  ifneq (,$(filter $(MIR_SUPPORTED_ARCH),$(DEB_HOST_ARCH)))

(Needs Fixing because of the arm bit if nothing else.)

Also, why did you delete the --disable-altivec configuration for powerpc?  That looks like a mistake.
-- 
https://code.launchpad.net/~brandontschaefer/libsdl/enable-mir-support-ffe/+merge/212072
Your team Ubuntu branches is subscribed to branch lp:ubuntu/libsdl2.



More information about the Ubuntu-reviews mailing list