[Merge] lp:~taihsiangho/ubuntu/precise/pcmanx-gtk2/fix-for-1284447 into lp:ubuntu/precise/pcmanx-gtk2

[Taihsiang Ho]

Taihsiang Ho has proposed merging lp:~taihsiangho/ubuntu/precise/pcmanx-gtk2/fix-for-1284447 into lp:ubuntu/precise/pcmanx-gtk2.

Requested reviews:
  Ubuntu branches (ubuntu-branches)

For more details, see:
https://code.launchpad.net/~taihsiangho/ubuntu/precise/pcmanx-gtk2/fix-for-1284447/+merge/211676

This is a function enhancement for LP: #1284447 and backport from upstream.
Please see the upstream bug report
https://code.google.com/p/pcmanx-gtk2/issues/detail?id=67&can=1

[Test Case]
open few connection windows, and then
* middle click to close what your middle button select - verify the new feature
* alt+w button to close the current window - verify the OnCloseCon behavior is the same after refactoring
* ctrl+d button to close the current window - verify the OnCloseCon behavior is the same after refactoring

[Regression Potential]
No, this is a userspace application to connect a telnet message window.
The most risk is the user could not close the exact telnet message window launched by the pcmanx-gtk2 application.
-- 
https://code.launchpad.net/~taihsiangho/ubuntu/precise/pcmanx-gtk2/fix-for-1284447/+merge/211676
Your team Ubuntu branches is requested to review the proposed merge of lp:~taihsiangho/ubuntu/precise/pcmanx-gtk2/fix-for-1284447 into lp:ubuntu/precise/pcmanx-gtk2.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5443 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140319/9d8e5ca8/attachment.diff>