[Merge] lp:~jjo/bash-completion/fix-bash43-quote_readline_by_ref-tilde-and-double_escaping into lp:ubuntu/bash-completion

JuanJo Ciarlante juan.ciarlante at canonical.com
Thu Mar 13 22:07:06 UTC 2014

Hi Martin,

> Hello JuanJo,
> thanks for these fixes! However, the
> debian/patches/words_bad_array_subscript.patch bit collides with a different
> fix from Jan Gerber (bug 1289597), so this needs to be dropped.

Indeed, likely a mishandling on my side :parent branch and :push

> The other changes need to be done as proper debian/patches/, too (and
> separated by issue if possible). Did you author them? If yes, can you please
> send them to upstream? If no, where did you get them from? We need this to
> track the patch and get it into Debian and Upstream, as it's certainly not
> Ubuntu specific.

I authored them indeed. Besides fixing ~3 different issues, the lines are
so close that would make patches to have a strict order/dependency and
traces from each (thus kinda defeating a 1-patch-per-issue approach somehow).

Question (as I'm a total newbie regarding ubuntu/debian/upstream workflows):
it's not necessary to wait upstream to have them applied right ?
- thinking on trusty release happening in ~1month, and an army of thousand
cmdliners hating it because of its broken completion :)

> Please set back the status (at the top of the page) to "needs review" when
> this is sorted out.

Thanks, will do.

> Thank you!

Your team Ubuntu branches is subscribed to branch lp:ubuntu/bash-completion.

More information about the Ubuntu-reviews mailing list