[Merge] lp:~sdeziel/ubuntu/precise/xl2tpd/fix-for-lp1244780 into lp:ubuntu/precise/xl2tpd
Robie Basak
robie.basak at canonical.com
Tue Mar 11 12:42:58 UTC 2014
Hi Simon,
Thank you for your work. I appreciate that it's frustrating to have to keep going round especially with multiple users, so I've asked Jamie to take a look, since I'd prefer to avoid being yet another reviewer round-tripping you again.
12:40 <rbasak> jdstrand: I'm unhappy to upload because 1) there are three
patches, but the bug implies one and the changelog entry
describes two; and 2) I'm unfamiliar with the package, and the
test case isn't detailed enough for me to follow it. But for my
latter objection, I appreciate that this is one of those interop
things that needs an affected user to do the SRU verification
anyway, and clearly Simon will be able to do it, so it's only a
weak objection.
12:40 <rbasak> jdstrand: I'd appreciate your opinion. If you think it's good, I
can test and upload as-is.
12:41 <rbasak> sdeziel: ^^
--
https://code.launchpad.net/~sdeziel/ubuntu/precise/xl2tpd/fix-for-lp1244780/+merge/194247
Your team Ubuntu branches is subscribed to branch lp:ubuntu/precise/xl2tpd.
More information about the Ubuntu-reviews
mailing list