[Merge] lp:~marcoceppi/ubuntu/precise/charm-tools/lp1223229 into lp:ubuntu/precise/charm-tools

Robie Basak robie.basak at canonical.com
Tue Mar 11 12:15:26 UTC 2014


Review: Needs Fixing

Hi Marco!

Thank you for the fix. This looks reasonable, but for an SRU to Precise we need a public bug, with SRU justification filled out, and the changelog entry to refer to that bug.

I'm also a little baffled by the lp:ubuntu/precise/charm-tools branch. It is ahead of the version actually in Precise. We can only upload SRU justified fixes, so I can do this minimal fix, but not the previous changes this branch is based on but which were never uploaded to Precise. If this is confusing, don't worry about it - if you can do the bug and update this branch, I can fix it up on upload.
-- 
https://code.launchpad.net/~marcoceppi/ubuntu/precise/charm-tools/lp1223229/+merge/209542
Your team Ubuntu branches is subscribed to branch lp:ubuntu/precise/charm-tools.



More information about the Ubuntu-reviews mailing list