[Merge] lp:~allgi/ubuntu/saucy/remmina/fix-vnc-plugin-repeater into lp:ubuntu/saucy/remmina
Marc Deslauriers
marc.deslauriers at canonical.com
Fri Mar 7 14:23:05 UTC 2014
Review: Disapprove
Thanks for the debdiff.
It looks like libvncserver 0.9.9 removed LIBVNCSERVER_WITH_CLIENT_TLS, but has LIBVNCSERVER_HAVE_GNUTLS.
Instead of simply checking for gnutls, and assuming libvncserver was built with it, I would rather you write a patch that makes vnc_plugin.c check for LIBVNCSERVER_HAVE_GNUTLS as well as LIBVNCSERVER_WITH_CLIENT_TLS.
Also, please add headers to your patch, as per:
http://dep.debian.net/deps/dep3/
Thanks!
--
https://code.launchpad.net/~allgi/ubuntu/saucy/remmina/fix-vnc-plugin-repeater/+merge/208969
Your team Ubuntu branches is subscribed to branch lp:ubuntu/saucy/remmina.
More information about the Ubuntu-reviews
mailing list