[Merge] lp:~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Jun 25 16:27:21 UTC 2014


Review: Needs Fixing

This implementation, with m_entries and m_orderedEntries, duplicates each entry as it is stored separately in a map and in a list. It looks like we could get rid of m_entries, and use m_orderedEntries instead (or maybe, for efficiency, keep a separate list of URLs for which an entry exists).
-- 
https://code.launchpad.net/~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp/+merge/224117
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list