[Merge] lp:~phablet-team/ofono/low-power-mode-et-al into lp:~phablet-team/ofono/ubuntu
Tony Espy
espy at canonical.com
Tue Jun 24 19:10:34 UTC 2014
Tony Espy has proposed merging lp:~phablet-team/ofono/low-power-mode-et-al into lp:~phablet-team/ofono/ubuntu.
Commit message:
* src/network.c, src/simutil.c: use OF_OPL to check roaming status
* rilmodem/sim.c, plugins/ril.c, android-spn-table.c: fix memory leaks
* test: adapt test scripts to multi-sim scenarios
* build, drivers/mtkmodem, drivers/rilmodem, gril: add Low-Power mode
This change adds RadioSettings low-power support by leveraging
the existing FastDormancy property to control entering/exiting low-
power mode. This change also includes support for mtkmodem, which
uses MTK-specific requests to handle the same logic.
* src/network.c: re-order emission of signals in network atom
This change ensures that the NetworkRegistration 'Technology'
property is emitted before 'CellId'. This change was made
to fix an issue with a third party location service.
* test/rilmodem/*: update for Python3, minor cleanup
Besides the Python3 change, this change revises some
of the tests as the Touch emulator now supports additional
modem properties which weren't previously exposed.
* build, include, plugins, test: re-merge Nettime code from github
Nettime had been previously added directly to bzr, but wasn't
present in our upstream github repo for ofono, which caused a
conflict every time we merged from lp:~phablet-team/ofono/rilmodem
( our auto-import tree ).
* test/get-network-time: convert to Python3 & add support multi-SIM
Requested reviews:
Ubuntu Phablet Team (phablet-team)
For more details, see:
https://code.launchpad.net/~phablet-team/ofono/low-power-mode-et-al/+merge/224347
This branch includes two changes:
1. Re-work a few of the ofono test scripts to handle multi-SIM
2. Fix a roaming issue which affects certain MVNOs. See the original pull request for more details ( including testing details ):
https://github.com/rilmodem/ofono/pull/86
3. Fixes some memory leaks
4. Adds low-power support via RadioSettings 'FastDormancy' property
5. Re-orders emissions of NetworkRegistration signals to ensure that 'Technology' changes are notified before 'CellId'.
6. Additional Python3 changes to test scripts, and cleanup of ToDo items in tests/rilmodem due
to recent improvements to the Touch emulator.
7. Re-merged nettime code from git, to prevent conflicts with locally added nettime code ( no
functional difference ).
--
https://code.launchpad.net/~phablet-team/ofono/low-power-mode-et-al/+merge/224347
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/ofono/low-power-mode-et-al into lp:~phablet-team/ofono/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 57015 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140624/937ade28/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list