[Merge] lp:~artmello/gallery-app/gallery-app-fix_toolbar_device into lp:gallery-app

Arthur Mello arthur.mello at canonical.com
Sat Jun 21 03:51:22 UTC 2014


Arthur Mello has proposed merging lp:~artmello/gallery-app/gallery-app-fix_toolbar_device into lp:gallery-app.

Commit message:
Do not set fullscreen by default if we are not on Desktop.
This seems to get the wrong window height on devices and makes toolbar failing to work.
Also it seems unnecessary to set fullscreen on devices.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1332632 in gallery-app: "can't display toolbar after dismissing it"
  https://bugs.launchpad.net/gallery-app/+bug/1332632

For more details, see:
https://code.launchpad.net/~artmello/gallery-app/gallery-app-fix_toolbar_device/+merge/224013

Do not set fullscreen by default if we are not on Desktop.
This seems to get the wrong window height on devices and makes toolbar failing to work.
Also it seems unnecessary to set fullscreen on devices.
-- 
https://code.launchpad.net/~artmello/gallery-app/gallery-app-fix_toolbar_device/+merge/224013
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~artmello/gallery-app/gallery-app-fix_toolbar_device into lp:gallery-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 448 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140621/4c5931d6/attachment.diff>


More information about the Ubuntu-reviews mailing list