[Merge] lp:~mterry/phablet-tools/welcome-wizard-disable into lp:phablet-tools
Michael Terry
michael.terry at canonical.com
Fri Jun 20 14:48:10 UTC 2014
1) Is this a no-op if ubuntu-system-settings-wizard is not available? I'm just making sure this change doesn't need to be in lock-step with some other change.
- Yes, it's a no-op. Just adds/removes a file that only the wizard looks at.
2) Are there cases when we don't want to disable this wizard? I can see that for all of our current testing this is needed. Do we have a testing gap for this wizard that we eventually need to cover?
- Maybe? I think for AP tests, we can just add/remove the file in the AP test and restart the upstart job with testability. So it should be fine that for all our current testing we disable it.
3) Just to make a note, it would be helpful to have a single option which disabled both the intro and the welcome-wizard and could be used as an umbrella option for any other tweak that needs to be done before automated tests can run. But I can see this being outside the scope of this MP and don't want to bog this one down.
- Agreed on all points.
--
https://code.launchpad.net/~mterry/phablet-tools/welcome-wizard-disable/+merge/223766
Your team Ubuntu Phablet Team is subscribed to branch lp:phablet-tools.
More information about the Ubuntu-reviews
mailing list