[Merge] lp:~mandel/udm/add-uploads into lp:udm
Sergio Schvezov
sergio.schvezov at canonical.com
Wed Jun 18 14:04:14 UTC 2014
Review: Needs Fixing
Testing gives me this:
runtime.SetFinalizer: cannot pass *udm.FileUpload to finalizer func(*udm.FileDownload)
fatal error: runtime.SetFinalizer
goroutine 46 [running]:
runtime.throw(0x31e416)
/usr/lib/go/src/pkg/runtime/panic.c:464 +0x5c fp=0xb6d4ac10
runtime.SetFinalizer(0x18bd60, 0x1067a960, 0x15b3d0, 0x1cd720)
/usr/lib/go/src/pkg/runtime/malloc.goc:800 +0x44 fp=0xb6d4ac50
launchpad.net/udm.newFileUpload(0x1067af00, 0x1067a0f0, 0x45, 0xb6f79ca8, 0x0, ...)
/home/sergiusens/projects/go/src/launchpad.net/udm/uploader.go:128 +0x4c8 fp=0xb6d4ad20
launchpad.net/udm.(*UploadManager).CreateMmsUpload(0x10686a68, 0x10684d20, 0x17, 0x10676c00, 0x54, ...)
/home/sergiusens/projects/go/src/launchpad.net/udm/uploader.go:394 +0x308 fp=0xb6d4ad9c
launchpad.net/nuntium/mms.Upload(0x10676c00, 0x54, 0x10684d20, 0x17, 0x10684d00, ...)
/home/sergiusens/projects/go/src/launchpad.net/nuntium/mms/download.go:67 +0x8c fp=0xb6d4aeb0
main.(*Mediator).uploadFile(0x10656540, 0x10676c00, 0x54, 0x0, 0x0)
/home/sergiusens/projects/go/src/launchpad.net/nuntium/mediator.go:306 +0x42c fp=0xb6d4af78
main.(*Mediator).sendMNotifyRespInd(0x10656540, 0x10676c00, 0x54)
/home/sergiusens/projects/go/src/launchpad.net/nuntium/mediator.go:242 +0x74 fp=0xb6d4afb8
runtime.goexit()
/usr/lib/go/src/pkg/runtime/proc.c:1394 fp=0xb6d4afb8
created by main.(*Mediator).init
/home/sergiusens/projects/go/src/launchpad.net/nuntium/mediator.go:99 +0x36c
Here's a full paste: http://paste.ubuntu.com/7663845/
--
https://code.launchpad.net/~mandel/udm/add-uploads/+merge/219201
Your team Ubuntu Phablet Team is subscribed to branch lp:udm.
More information about the Ubuntu-reviews
mailing list